Rollup of 6 pull requests #91775
Closed
Rollup of 6 pull requests #91775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As suggested in rust-lang#88564. This adds a `try_clone()` to `OwnedFd` by refactoring the code out of the existing `File`/`Socket` code.
This commit also updates `stdarch` git submodule.
Keep track of the origin of a `T: Future` obligation when caused by an `.await` expression. Address rust-lang#66731.
…" suggestion Keep the `HirId` of `.await`ed expressions so in the case of a `fn` call on on a sync `fn`, we can suggest maybe turning it into an `async fn`.
The spans no longer overlap, so we no longer need to specialize the output depending on whether they would.
…` point
```
error[E0759]: `self` has an anonymous lifetime `'_` but it needs to satisfy a `'static` lifetime requirement
--> $DIR/issue-72312.rs:10:24
|
LL | pub async fn start(&self) {
| ^^^^^ this data with an anonymous lifetime `'_`...
...
LL | require_static(async move {
| -------------- ...is required to live as long as `'static` here...
LL | &self;
| ----- ...and is captured here
|
note: `'static` lifetime requirement introduced by this trait bound
--> $DIR/issue-72312.rs:2:22
|
LL | fn require_static<T: 'static>(val: T) -> T {
| ^^^^^^^
error: aborting due to previous error
For more information about this error, try `rustc --explain E0759`.
```
Fix rust-lang#72312.
* take diagnostic logic out of happy-path * sort/dedup once * add more comments
More accurate filtering still needed.
|
@bors r+ rollup=never p=6 |
|
📌 Commit 1305bc5 has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit 1305bc5 with merge edb8af266eb17db69b7760b377465172f4ef4b22... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
Looks like a github connection problem :( |
bors
added
S-waiting-on-bors
|
mmh wait now, maybe we are referencing the wrong commit in a git dep somewhere... |
bors
added
S-waiting-on-author
|
Hmm, but the commit exists and is part of master apparently ... |
bors
added
S-waiting-on-bors
|
@bors r+ |
|
📌 Commit 1305bc5 has been approved by |
|
⌛ Testing commit 1305bc5 with merge ba1d81a523e0a2510a7a51016d01dacb0e5f7802... |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
try_clone()function toOwnedFd. #88794 (Add atry_clone()function toOwnedFd.)'staticreference crossing ayieldpoint #89734 (Point at capture points for non-'staticreference crossing ayieldpoint)BorrowandBorrowMutimplsconst#90270 (MakeBorrowandBorrowMutimplsconst)for-loop,?and.awaitdesugaring #90939 (Tweak errors coming fromfor-loop,?and.awaitdesugaring)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup